Feature/update readme - #102
Conversation
sjbalagit
left a comment
sjbalagit
left a comment
There was a problem hiding this comment.
Hi Shreya, looks good. I requested two minor changes. Please review and update. Thanks!
|
|
||
| ```bash | ||
| pip install geospatial_toolkit | ||
| pip install -i https://test.pypi.org/simple/ geospatial-toolkit |
There was a problem hiding this comment.
This link doesn't work for geopy issues. Please use -
pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ geospatial-toolkit
| # 'd' stands for degree | ||
| gst.standardize_latlong("34d3'8\"N", "118d14'37\"W") | ||
| # 1. Standardize latitude and longitude | ||
| gst.standardize_latlong("34° 3' 8\" N", "118° 14' 37\" W") |
There was a problem hiding this comment.
Probably the recent changes weren't pulled into this branch. Also updated the demo because the older version was not working. please update to -
# 'd' stands for degree
gst.standardize_latlong('34d3'8"N', '118d14'37"W')
There was a problem hiding this comment.
My apologies, I see my error. Thanks for pointing that out
sjbalagit
left a comment
sjbalagit
left a comment
There was a problem hiding this comment.
Looks great, thanks for making the changes!
2 participants
fix Update README based on peer review #101
address feedback from Peer Review - Mara Sanchez #68
added a dataframe for the
point_to_cityfunction demoupdated user installation instructions
updated developer instructions
updated documentation instructions (include note on
nbformat)